Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): fix async stack and message maybe include \n #117

Merged
merged 2 commits into from
Mar 29, 2021
Merged

fix(notification): fix async stack and message maybe include \n #117

merged 2 commits into from
Mar 29, 2021

Conversation

iamcco
Copy link
Owner

@iamcco iamcco commented Mar 29, 2021 •
edited
Loading

closes #116

@iamcco iamcco mentioned this pull request Mar 29, 2021
Closed
@Kavantix
Copy link
Collaborator

This indeed fixes the error for me and the floating notification also still works so merging and publishing together with the devices list under 1.9.2 :)

@Kavantix Kavantix merged commit d4c6f3d into master Mar 29, 2021
@iamcco iamcco deleted the fix/notification branch March 29, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resumeNotification not called within same tick: Error
2 participants
@iamcco @Kavantix